Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Simple Pen support Proposal #242

Open
techninja opened this issue Nov 18, 2015 · 5 comments
Open

Super Simple Pen support Proposal #242

techninja opened this issue Nov 18, 2015 · 5 comments

Comments

@techninja
Copy link
Contributor

It seems I've gone off the deep end with my musings on an all encompassing system like #234, when really we've been wondering where simple & uncomplicated pen support has been for years.

Truth is, it's not far off, here's an attempt to describe the transition to a minimum viable solution:

  • Add a new colorset type, pen (stuck in colorset config JSON)
  • pen type sets display slightly differently, with a generic pen picture and custom color, only selectable when in pen/pencil mode.
  • Tool change between colors is "pause/wait for change". Will require RP wide notification for which pen to put in, and shove to calibration before continuing.
  • Provide the following basic pen sets:
    • One black pen, default. Description will detail that if you only have one thing, it doesn't matter what it is, just use this.
    • Basic Color Pen Set: Same as crayola watercolor set, just with pens
    • Custom pen set. Need to come up with a very basic definition of what this is, but the bare minimum we need is a color picker and a pen name to go with it.
@oskay
Copy link
Contributor

oskay commented Apr 19, 2016

This is an excellent idea. I'd be very happy to have this functionality present, even if we don't yet support custom pen sets.

@techninja
Copy link
Contributor Author

@oskay Finally got some time to get this silly thing out of the way. This is what it looks like when a manualswap is triggered. the __color__ would be replaced with whatever the translated RP name for the given tool index is (99% of the time is going to be a color).

robopaint _053

Text is.. OK at best. along with the tool definition we can tell what this is, so I can have it say "...insert the blue pen/pencil" instead of awkward "..insert the blue color" 😕, though I'll hold off till I hear your suggestion.

The use of "unlocked" is to remove the "unlock" button, so by default after we park, the motors will become unlocked for users who want to calibrate everything themselves.

@techninja
Copy link
Contributor Author

techninja commented Nov 9, 2016

Apparently CNCServer API never had support for unlocking the motors while paused! Whoops. Turns out that's an obvious requirement to do this at all. Sheesh.

@techninja
Copy link
Contributor Author

The PR for this work is in #287

New screenshot:
robopaint _054

Full text for all the buttons/options:

"manual": {
      "status": "Waiting for manual change...",
      "notice": "Please insert the __color__ __type__ to continue",
      "info": "Motors unlocked for calibration, use the toggle button find the correct draw height, ensure the pen is put back in park position, then click continue to resume drawing.",
      "resume": "Now drawing with __color__",
      "options": {
        "cancel": {
          "title": "Cancel Print",
          "info": "Cancel the current print job, close the mode and return to the home screen."
        },
        "continue": {
          "title": "Continue drawing with __color__",
          "info": "Once you've finished changing to the correct drawing implement, click to continue drawing."
        },
        "toggle": {
          "title": "Toggle height",
          "info": "Toggle the raising/lowering of the pen to calibrate its height."
        }
      }
    }

@forresto
Copy link

FWIW, I did this manually by editing the SVG source, and switching pens 6 times. The alignment was a little unpredictable, but I find the imperfection charming:

labyrinth-21-robopaint
https://twitter.com/forresto/status/1182675515850874880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants