swap: expand RPC calls for cheque info querying #1863

mortelli · 2019-10-04T15:23:40Z

This PR builds on the work done in #1842 with the aim of implementing (at least some of) issue #1445.

Its main purpose is to improve RPC calls to query cheque information.

Changes:

adds the Cheques function, which returns all known cheques. This includes both last sent as well as last received, and for peers in memory and on disk.
adds the PeerCheques function, which returns the last known sent and received cheques for a specific peer.
these new functions differ from the previous RPC calls because those were limited by cheque type. Said calls are therefore removed (as are their tests) since their original functionality is now superseded.
improved coverage of existing tests.
improved comments.
piggybacks renaming storeKeysTestCases struct to storeKeysTestCase

…unctions

…ction

swap/swap_test.go

…tire TestCheques function

mortelli · 2019-10-25T18:39:06Z

Both tests have been re-written in table-driven form.

The PR description has been updated and reviews have been re-requested.

mortelli · 2019-10-28T20:36:07Z

added new PeerCheques struct for increased readability/maintainability.

both Cheques and PeerCheques functions make use of this struct.

as a result, the response keys are no longer needed.

# Conflicts: # swap/protocol.go # swap/swap.go

mortelli added 2 commits October 3, 2019 16:21

swap: add PeerCheques function to swapAPI and Swap struct

2938485

swap: change PeerCheques signature so that it is callable through RPC

35b9f23

mortelli added in progress incentives labels Oct 4, 2019

mortelli self-assigned this Oct 4, 2019

mortelli mentioned this pull request Oct 4, 2019

RPC endpoint for querying cheque information #1445

Closed

mortelli added 24 commits October 4, 2019 15:57

swap: first working Cheques implementation

7db5774

swap: fix deadlock in Cheques

ea1a291

Merge remote-tracking branch 'origin/master' into swap-query-cheque-info

ab7d4af

swap: fix impossible condition in Cheques function

a9af5e1

Merge remote-tracking branch 'origin/master' into swap-query-cheque-info

bc9dbde

swap: update comments in swapAPI functions

8e6cc20

swap: rename tests for consistency

589579b

swap: start re-implementing Cheques function

6345406

swap: add TestReceivedCheques function

137efc8

swap: iterate TestSentCheques

db019a8

swap: refactor TestSentCheques, TestReceivedCheques and testCheques f…

0b91f32

…unctions

swap: add TestPeerCheques and testLastCheques functions

b4daa5a

swap: add additiona lerror checks to TestBalance function

2e72bcf

swap: add additional error checks to TestBalances function

1df044e

swap: add additional error checks to TestSentCheques function

d1f42cc

swap: add additional error checks to TestReceivedCheques function

de08de5

swap: iterate TestPeerCheques function

5418acb

swap: update comments in swap tests for consistency

d08c45d

swap: iterate TestPeerCheques

9136a66

swap: iterate TestPeerCheques

48bb5dd

swap: iterate TestPeerCheques

941eb59

swap: iterate TestPeerCheques and PeerCheques functions

e655c46

swap: iterate Cheques function

93948c9

swap: extract lastSentChequeKey and lastReceivedChequeKey consts

c2b0c87

mortelli added 5 commits October 24, 2019 16:07

swap: iterate TestChequesNew function

01930bd

swap: iterate TestChequesNew function

a3e0a30

swap: add name to chequesTestCases struct, iterate TestChequesNew fun…

5818da1

…ction

swap: iterate TestChequesNew function

9b11c9d

swap: remove saveNewSentCheque and saveNewReceivedCheque functions

1d5cd24

acud suggested changes Oct 25, 2019

View reviewed changes

swap/swap_test.go Outdated Show resolved Hide resolved

mortelli added 9 commits October 25, 2019 11:50

Merge remote-tracking branch 'origin/master' into swap-query-cheque-info

1fbff32

swap: name fields in test cases

9036b66

swap: add peerChequesTestCase struct, TestPeerChequesNew function, re…

393a5fe

…tire TestCheques function

swap: iterate TestPeerChequesNew function

dc6057d

swap: iterate TestPeerChequesNew function

754195d

swap: add testPeerChequesInvalid function

e1faa17

swap: iterate TestPeerChequesNew function

62e2af2

swap: retire old peer cheques tests

e0bbf0c

swap: retire deprecated cheques test auxiliary functions

616fa40

mortelli requested a review from acud October 25, 2019 18:39

mortelli added 3 commits October 28, 2019 14:18

Merge remote-tracking branch 'origin/master' into swap-query-cheque-info

386dd59

swap: add PeerCheques struct

a7c51c2

swap: change Cheques signature so that it uses PeerCheques struct

d7df692

mortelli added 2 commits October 29, 2019 12:20

swap: refactor cheques tests

63972db

Merge remote-tracking branch 'origin/master' into swap-query-cheque-info

e6060b9

# Conflicts: # swap/protocol.go # swap/swap.go

acud requested review from acud and removed request for acud October 30, 2019 11:26

acud approved these changes Oct 30, 2019

View reviewed changes

mortelli merged commit e34af5c into master Oct 30, 2019

mortelli deleted the swap-query-cheque-info branch October 30, 2019 13:30

mortelli mentioned this pull request Nov 1, 2019

swap: prevent bad cheques from being sent #1925

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

swap: expand RPC calls for cheque info querying #1863

swap: expand RPC calls for cheque info querying #1863

mortelli commented Oct 4, 2019 •

edited

Loading

mortelli commented Oct 25, 2019

mortelli commented Oct 28, 2019

swap: expand RPC calls for cheque info querying #1863

swap: expand RPC calls for cheque info querying #1863

Conversation

mortelli commented Oct 4, 2019 • edited Loading

mortelli commented Oct 25, 2019

mortelli commented Oct 28, 2019

mortelli commented Oct 4, 2019 •

edited

Loading