Updates package.json and code to use latest ethereumjs-common version #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2019
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
2e63c71
to
e8f7d72
Compare
|
Have left a comment on ethereumjs/ethereumjs-common#46, please use the existing version of the |
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
e8f7d72
to
6451b75
Compare
|
@holgerd77 I have changed this to use the existing API |
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
6451b75
to
da97a00
Compare
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
da97a00
to
e6be3e1
Compare
|
Closing as the changes here are included in #433 They make sense as part of that PR, so this one is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ethereumjs-commonv1.0.0 will breakethereumjs-vmdue to changes in the directory structure and changes to thegenesisStatesinterface (name and structure).This PR updates the code to accomodate the import api changes in v1.0.0, while taking advantage of the changes proposed with ethereumjs/ethereumjs-common#46
Note: there is an outstanding bug that causes tests to fail on this branch. It is possible the bug was introduced with changes in ethereumjs-common that came with v1.0.0. I am investigating.(resolved)