Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add proofs to blobsbundle #2642

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Apr 14, 2023

Add proofs to blobsbundle and consequently to getblobsbundle engine api call so that CL doesn't need to compute proof which ideally would be coming packaged in the network wrapper serialized tx

ref:

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop-v7@41dfedc). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.44% <0.00%> (?)
blockchain 90.43% <0.00%> (?)
client 87.04% <0.00%> (?)
common 95.76% <0.00%> (?)
devp2p 91.80% <0.00%> (?)
ethash ∅ <0.00%> (?)
evm 79.35% <0.00%> (?)
rlp ∅ <0.00%> (?)
statemanager 87.73% <0.00%> (?)
trie 90.39% <0.00%> (?)
tx 95.45% <0.00%> (?)
util 81.50% <0.00%> (?)
vm 84.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 force-pushed the g11tech/add-proofs-blobsbundle branch from 09f1111 to aef3d40 Compare April 17, 2023 07:11
@holgerd77
Copy link
Member

Rebased this via UI

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have at least 1-2 small test cases for this so to minimally make sure that data is passed around and encoded/decoded in the correct format.

st.ok(pendingBlob !== undefined && equalsBytes(pendingBlob, blobs[0]))
const blobProof = blobBundle.proofs[0]
st.ok(blobProof !== undefined && equalsBytes(blobProof, proofs[0]))
Copy link
Contributor Author

@g11tech g11tech Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holgerd77 this checks if the bundle has the proof and valdiates it as well,

Also getBlobsBundle api is being removed (discussed in yesterdays 4844 call) and the bundle and payload is going to be included in a new getPayloadV3, so will make sure spec test for that will cover proof check in the bundle

@g11tech g11tech force-pushed the g11tech/add-proofs-blobsbundle branch from aef3d40 to 2f8c3f8 Compare April 18, 2023 05:25
@g11tech
Copy link
Contributor Author

g11tech commented Apr 18, 2023

rebased via UI again

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g11tech g11tech merged commit aa56f43 into develop-v7 Apr 18, 2023
@holgerd77 holgerd77 deleted the g11tech/add-proofs-blobsbundle branch April 18, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants