client: validate CLI args #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holgerd77, do you think it's worth writing a test for this? I'm tempted to leave testing out, as we'd basically just be testing |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabrocheleau
commented
Jan 19, 2023
gabrocheleau
force-pushed
the
client/validate-cli-args
branch
from
3076c09
to
16dc231
Compare
holgerd77
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Oh, that's fantastic! 🤩 Just tested with --rpcdebug (instead of --rpcDebug), works perfectly with then directly giving the help page (makes so much sense).
Sometimes the small changes are the best! 🙂
Will likely find a lot of other client UX improvement suggestions during interop 😋!
Will merge (no, don't think a test is required here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the CLI args parsing strict, meaning that unknown args will result in yargs throwing instead of them being ignored.
npm run client:start -- --invalidOptionnow results in: