Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfiles to use node 18 #2487

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Update Dockerfiles to use node 18 #2487

merged 1 commit into from
Jan 17, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jan 17, 2023

Using node18 locally and having no issues, it makes sense to update the dockerfiles to use node18

@g11tech g11tech added the target: master Work to be done towards master branch label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #2487 (98b2dca) into master (64d8d3c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.57% <ø> (ø)
blockchain 90.04% <ø> (ø)
client 87.89% <ø> (-0.02%) ⬇️
common 95.89% <ø> (ø)
devp2p 91.62% <ø> (+0.02%) ⬆️
ethash ∅ <ø> (∅)
evm 79.73% <ø> (ø)
rlp ?
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 97.80% <ø> (ø)
util 84.81% <ø> (ø)
vm 85.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g11tech g11tech merged commit 8bcdb48 into master Jan 17, 2023
@holgerd77 holgerd77 deleted the g11tech/update-docker-node18 branch March 2, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: client PR state: merge ready target: master Work to be done towards master branch type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g11tech @holgerd77