-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP-4844 #2349
Implement EIP-4844 #2349
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
3fe8446
to
b508fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short comment on first look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good 👍 just may be a couple of more cleanups away from merge
Okay, I think everything is basically done at this point. I don't have code coverage completely up to the 88% range but it's pretty close (upper 70s). |
@acolytec3 once we restore the shanghai.json's eip list, we are should be good to merge this! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
LGTM. Tschok, tschok. Merged! Wow, you did it. You guys are really brave! Congrats Andrew, Gajinder. Great work! |
This PR implements EIP-4844
fromNetworkWrapper
- deserialize a full network wrapper transaction (includes blobs, kzgProof)fromSerializedTx
- deserialize the "minimal" version (i.e. without kzgProof and blobs)serialize
- serializer for "minimal" versionserializeNetworkWrapper
- serializer for "network wrapper" version (including blobs/kzgProof)excessDataGas
field to block headerHASH
opcode to evmvm.runTx
c-kzg
or rust equivalent for verifying kzg proofsc-kzg
currently doesn't expose theverify_kzg_proof
andcommitment_to_point
methods we need to finish this out. Have an open issue on c-kzg to address.validateBlobNetworkWrapper
method that verifies blobs match kzg commitments and proof in network wrapper versionengine_getBlobsBundleV1
RPC endpoint to client- [ ] - Run client on interop devnet -- This is partially done. My fork contains dockerFiles and scripts to run our client with lodestar and we have been able to sync a chain and receive blob transactions frometh_sendRawTransaction
and then transmit those to lodestar via the engine APIs.tx.hash
function to usessz.serialize
Some additional references (edit by @holgerd77):