This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Update to ethereumjs-common v1.1.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2019
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
c1888ec
to
bbf96f2
Compare
whymarrh
approved these changes
Feb 1, 2019
holgerd77
suggested changes
Feb 4, 2019
There was a problem hiding this comment.
Same here, I think it would make sense to directly update this to v1.1.0 (so ^1.1.0 (once released), then the library will be more safe to be used in a Petersburg context and we can directly state this in the subsequent release notes here.
@danjm If you want you can directly update to safe time. I can then re-trigger CI once the new Common version is released.
holgerd77
suggested changes
Feb 4, 2019
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
bbf96f2
to
cc2fd89
Compare
|
@holgerd77 Updated ethereumjs-common to |
danjm
force-pushed
the
update-ethereumjs-common-version
branch
from
c15f383
to
d433265
Compare
|
Retriggered both builds here after v2.2.0 release of the block library. |
holgerd77
changed the title
holgerd77
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates code and package.json to use ethereumjs-common v1.1.0