This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Fix putBlock() edge case #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am low on time for the week, if someone else could jump in for the review would be glad! |
|
@vpulim I restarted one of the builds that had saw a Travis |
|
@whymarrh Sorry to be pushy, but the client is blocking on this in order to address a major stability bug. It looks like the travis build is passing now. Let me know if you have any questions on the code changes. Essentially, the change ensures that if any of the db ops fail in putBlock(), the whole operation fails. This will keep the db in the correct state in case anything goes wrong during a putBlock() operation. |
whymarrh
approved these changes
Dec 7, 2018
|
@whymarrh awesome! thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an intermittent bug in
putBlock()that is caused by_saveHeads()andbatchDbOps()not being executed as part of the same db transaction. If_saveHeads()completes butbatchDbOps()fails, it can lead to the head information being inconsistent with the actual head block.