This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
reviewed
Jul 26, 2019
@holgerd77 I updated this PR with the following changes:
|
@alcuadrado Ahm, you still have to set the |
Update: ah, I am getting something wrong, just seeing that you are directly assigning this to the specific valdation parameters. 😄 |
holgerd77
suggested changes
Jul 30, 2019
alcuadrado
force-pushed
the
granular-validation
branch
from
August 1, 2019 14:48
7d70aff
to
7ae5db9
Compare
There was a bug on how |
holgerd77
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #120
I tried adding a test for this at the end of the huge
async.series
call, but I can't get it run. It's ignored by tape. Any idea?