Add pre commit v6 #3296
Merged
Add pre commit v6 #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
add-pre-commit-v6
branch
from
f85cd73
to
b51ae27
Compare
pacrob
force-pushed
the
add-pre-commit-v6
branch
from
ad4c77d
to
551b683
Compare
fselmo
approved these changes
Mar 21, 2024
kclowes
approved these changes
Mar 22, 2024
web3/eth/async_eth.py
Outdated
| @@ -740,12 +740,14 @@ async def unsubscribe(self, subscription_id: HexStr) -> bool: | |||
| # -- contract methods -- # | |||
|
|
|||
| @overload | |||
| def contract(self, address: None = None, **kwargs: Any) -> Type[AsyncContract]: ... | |||
| def contract(self, address: None = None, **kwargs: Any) -> Type[AsyncContract]: # type: ignore # noqa: E501 | |||
There was a problem hiding this comment.
nit: might be worth a comment on why we're type: ignoreing here
…config to pyproject.toml
pacrob
force-pushed
the
add-pre-commit-v6
branch
from
551b683
to
69e0bbb
Compare
reedsa
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Add
pre-commit, move related config to pyproject.toml, run lintHow was it fixed?
Todo:
Cute Animal Picture