This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Sync with ethereum/eth2.0-specs#694: enhance get_beacon_proposer_index
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
changed the title
get_beacon_proposer_index
djrtwo
approved these changes
Mar 1, 2019
| ) | ||
| next_epoch = Epoch(current_epoch + 1) | ||
|
|
||
| validate_epoch_within_previous_and_next(epoch, previous_epoch, next_epoch) |
There was a problem hiding this comment.
This validation doesn't strictly have to happen here because it happens again within get_crosslink_committees_at_slot. That said, it's cheap and explicit is probably better :)
Co-Authored-By: hwwhww <hwwang156@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Spec PR: ethereum/consensus-specs#694
How was it fixed?
get_beacon_proposer_indexsafe for next epochregistry_changeflag fromget_committee_assignmenttoget_beacon_proposer_indexvalidate_epoch_for_current_epochtovalidate_epoch_within_previous_and_nextCute Animal Picture