Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial bits for integrating the LSP API. #609

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

christianparpart
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Feb 21, 2022

Coverage Status

Coverage decreased (-3.06%) to 80.526% when pulling a21be10 on lsp-integration into f853458 on master.

@christianparpart christianparpart force-pushed the lsp-integration branch 5 times, most recently from 1c76e96 to d66dd93 Compare February 21, 2022 15:19
wrapper.ts Outdated Show resolved Hide resolved
@chriseth
Copy link
Contributor

Looks good in general! Maybe we can actually just ignore the synchronous read problem for the first version.
Did you try building a vscode plugin on top of this?

Also @axic had some additional ideas for unifying the callback functions.

wrapper.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
wrapper.ts Outdated Show resolved Hide resolved
wrapper.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@stephen-slm stephen-slm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy Coding Style

All changes show entirely legacy coding style for Javascript and goes against best practices. Additionally the code is made increasingly more complicated than required with multiple nested functions which should not be const functions but well defined for typing.

  • Interfaces should be moved outside of wrapper.ts file.
  • no supporting tests for changes.
  • no linting

Just my two cents.

@@ -79,6 +79,8 @@ function setupMethods (soljson) {
const copyFromCString = soljson.UTF8ToString || soljson.Pointer_stringify;

const wrappedReadCallback = function (path: string, contents: string, error: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just run npm run lint:fix or the related package.json command to resolve these before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Implement
Development

Successfully merging this pull request may close these issues.

4 participants