update for travis/macos #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the necessity for ctrl+d is a drawback at all. That's typical when using your terminal to feed standard input to a process. |
axic
force-pushed
the
solcjs-standard
branch
2 times, most recently
from
4135f16
to
2cd5d8e
Compare
axic
force-pushed
the
solcjs-standard
branch
2 times, most recently
from
66377cb
to
2cd5d8e
Compare
leonardoalt
force-pushed
the
solcjs-standard
branch
2 times, most recently
from
00892bc
to
30b7a42
Compare
|
Thank you for your patch, this has now been fixed with #127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi there
this seems to work ok for me on moth macOS and travis, all tests pass
according to this nodejs/node#19831 in some cases it might work on windows as well, wasn't sure if it's of any concern
the one drawback to this, if you are not pipe ing and expect users to type in stdin, they will need to end with
ctrl+dthe text entry, pipe ing works finelet me know if this is ok, thank you for all your wonderful work