Skip to content
This repository has been archived by the owner on Aug 8, 2018. It is now read-only.

Downstream changes in pyethereum broke pyethapp #157

Closed
hackaugusto opened this issue Aug 5, 2016 · 0 comments
Closed

Downstream changes in pyethereum broke pyethapp #157

hackaugusto opened this issue Aug 5, 2016 · 0 comments
Labels

Comments

@hackaugusto
Copy link

pyethereum removed from exceptions import * from the processblock.py module.
ethereum/pyethereum@0d1fe01#diff-beaeda7ef37678886c5484018735a553L10

Some of the pyethapp relied on that indirection:

except processblock.InvalidTransaction:

except processblock.InvalidTransaction:

except processblock.InvalidTransaction as e:

except processblock.InvalidTransaction:

When theses code paths are hit a exception will be raised:

'module' object has no attribute 'InvalidTransaction'

@hackaugusto hackaugusto added the bug label Aug 5, 2016
hackaugusto added a commit to hackaugusto/pyethapp that referenced this issue Aug 5, 2016
konradkonrad added a commit that referenced this issue Aug 22, 2016
konradkonrad added a commit that referenced this issue Aug 22, 2016
Changelog:
- added OR event filter support in `JSONRPCClient` #160 #168 #149
- add ssl-protocol option to `JSONRPCClient` #166 #163
- add content-type header to `JSONRPCClient` #165 #164
- fix license documentation in `setup.py` #167
- bugfix for exception import regression #158 #157
- add check for OOG on `deploy_solidity_contract` #151
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant