-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements All G2 ciphersuites from the BLS Standards #83
Conversation
I'd appreciate some assistance with the interfaces. Specifically, the way the cipher suites are implemented. Currently each ciphersuite is a file, but this leads to unused imports as certain functions needn't be redefined by the specific ciphersuite. The most obvious solution is to make each ciphersuite a folder with an |
@CarlBeek
|
@hwwhww, I agree classes make this much cleaner. I was avoiding them to be more zen 🧘♂️but it backfired. What I don't like about what I've done now is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nitpicking.
This PR is ready for merge! 🎉Thereafter we can merge |
What was wrong?
py_ecc
did not implement the interfaces specified by the BLS standards.How was it fixed?
By refactoring how the BLS API was implemented by building modular components that allowed for all the ciphersuites to be implemented.
Cute Animal Picture
I saw a few baby warthogs in the bush last weekend.