Fix failing tests after updating fixtures #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update fixture to ``v12.4`` - It looks as though these tests hadn't been updated in a long time. There were failing tests but they did not reflect issues with the library, only issues in the test setup. The order of the updates was not being preserved for some tests where this is crucial. These changes only perform permutations on tests where there aren't updates to the same key value and the key still exists in the final state (is not deleted). For those tests, we have to preserve the update order.
fselmo
force-pushed
the
fix-failing-tests
branch
from
a9c7fc2
to
dfd57d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #126
closes #131
v12.4(commit hash 6613563)Todo:
Cute Animal Picture