Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert .format to f-strings, other cleanup #138

Merged
merged 1 commit into from
May 31, 2023
Merged

convert .format to f-strings, other cleanup #138

merged 1 commit into from
May 31, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented May 25, 2023 •
edited
Loading

What was wrong?

Old-style .format strings were still being used.

How was it fixed?

Converted to f-strings, plus other typo fixes and cleanup

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the cleanup-typos-and-formatting branch from d020e5f to b3d08c5 Compare May 25, 2023 20:55
@pacrob pacrob requested a review from kclowes May 25, 2023 20:59
kclowes
kclowes approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pacrob pacrob force-pushed the cleanup-typos-and-formatting branch from b3d08c5 to 9068264 Compare May 31, 2023 15:28
@pacrob pacrob merged commit debab1c into ethereum:master May 31, 2023
@pacrob pacrob deleted the cleanup-typos-and-formatting branch May 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacrob @kclowes