ethereumjs: add faster local test dockerfile #940
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ethereumjs-monorepo/packages/ethereum-tests | ||
| ethereumjs-monorepo/packages/*/node_modules | ||
| ethereumjs-monorepo/packages/vm/benchmarks | ||
| ethereumjs-monorepo/node_modules | ||
| !ethereumjs-monorepo/node_modules/@ethereumjs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Startup script to initialize and boot a ethereum-js instance. | ||
| # | ||
| # This script assumes the following files: | ||
| # - `genesis.json` file is located in the filesystem root (mandatory) | ||
| # - `chain.rlp` file is located in the filesystem root (optional) | ||
| # - `blocks` folder is located in the filesystem root (optional) | ||
| # - `keys` folder is located in the filesystem root (optional) | ||
| # | ||
| # This script assumes the following environment variables: | ||
| # | ||
| # - HIVE_BOOTNODE enode URL of the remote bootstrap node | ||
| # - HIVE_NETWORK_ID network ID number to use for the eth protocol | ||
| # - HIVE_NODETYPE sync and pruning selector (archive, full, light) | ||
| # | ||
| # Forks: | ||
| # | ||
| # - HIVE_FORK_HOMESTEAD block number of the homestead hard-fork transition | ||
| # - HIVE_FORK_DAO_BLOCK block number of the DAO hard-fork transition | ||
| # - HIVE_FORK_DAO_VOTE whether the node support (or opposes) the DAO fork | ||
| # - HIVE_FORK_TANGERINE block number of Tangerine Whistle transition | ||
| # - HIVE_FORK_SPURIOUS block number of Spurious Dragon transition | ||
| # - HIVE_FORK_BYZANTIUM block number for Byzantium transition | ||
| # - HIVE_FORK_CONSTANTINOPLE block number for Constantinople transition | ||
| # - HIVE_FORK_PETERSBURG block number for ConstantinopleFix/PetersBurg transition | ||
| # - HIVE_FORK_ISTANBUL block number for Istanbul transition | ||
| # - HIVE_FORK_MUIRGLACIER block number for Muir Glacier transition | ||
| # - HIVE_FORK_BERLIN block number for Berlin transition | ||
| # - HIVE_FORK_LONDON block number for London | ||
| # | ||
| # Clique PoA: | ||
| # | ||
| # - HIVE_CLIQUE_PERIOD enables clique support. value is block time in seconds. | ||
| # - HIVE_CLIQUE_PRIVATEKEY private key for clique mining | ||
| # | ||
| # Other: | ||
| # | ||
| # - HIVE_MINER enable mining. value is coinbase address. | ||
| # - HIVE_MINER_EXTRA extra-data field to set for newly minted blocks | ||
| # - HIVE_LOGLEVEL client loglevel (0-5) | ||
| # - HIVE_GRAPHQL_ENABLED enables graphql on port 8545 | ||
| # - HIVE_LES_SERVER set to '1' to enable LES server | ||
|
|
||
|
|
||
| # Immediately abort the script on any error encountered | ||
| set -e | ||
|
|
||
| cd /ethereumjs-monorepo/packages/client/ | ||
|
|
||
| ethereumjs="ts-node /ethereumjs-monorepo/packages/client/bin/cli.ts" | ||
| FLAGS="--gethGenesis /genesis.json --rpc --rpcEngine --saveReceipts --rpcAddr 0.0.0.0 --rpcEngineAddr 0.0.0.0 --rpcEnginePort 8551 --ws false --logLevel debug --rpcDebug all --rpcDebugVerbose all --isSingleNode" | ||
|
|
||
| # Configure the chain. | ||
| mv /genesis.json /genesis-input.json | ||
| jq -f /mapper.jq /genesis-input.json > /genesis.json | ||
|
|
||
| # Dump genesis. | ||
| if [ "$HIVE_LOGLEVEL" -lt 4 ]; then | ||
| echo "Supplied genesis state (trimmed, use --sim.loglevel 4 or 5 for full output):" | ||
| jq 'del(.alloc[] | select(.balance == "0x123450000000000000000"))' /genesis.json | ||
| else | ||
| echo "Supplied genesis state:" | ||
| cat /genesis.json | ||
| fi | ||
|
|
||
| # Import clique signing key. | ||
| if [ "$HIVE_CLIQUE_PRIVATEKEY" != "" ]; then | ||
| # Create password file. | ||
| echo "Importing clique key..." | ||
| echo -n "$HIVE_CLIQUE_PRIVATEKEY" > /private_key.txt | ||
| # Ensure password file is used when running ethereumjs in mining mode. | ||
| if [ "$HIVE_MINER" != "" ]; then | ||
| FLAGS="$FLAGS --mine --unlock /private_key.txt --minerCoinbase $HIVE_MINER" | ||
| fi | ||
| fi | ||
|
|
||
| if [ "$HIVE_TERMINAL_TOTAL_DIFFICULTY" != "" ]; then | ||
| FLAGS="$FLAGS --jwt-secret /jwtsecret" | ||
| fi | ||
|
|
||
| # Load the test chain if present | ||
| echo "Loading initial blockchain..." | ||
| if [ -f /chain.rlp ]; then | ||
| FLAGS="$FLAGS --loadBlocksFromRlp=/chain.rlp" | ||
| else | ||
| echo "Warning: chain.rlp not found." | ||
| fi | ||
|
|
||
| if [ "$HIVE_BOOTNODE" != "" ]; then | ||
| FLAGS="$FLAGS --bootnodes=$HIVE_BOOTNODE" | ||
| fi | ||
| echo "Running ethereumjs with flags $FLAGS" | ||
| $ethereumjs $FLAGS |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of splitting out all these COPY lines. I guarantee they will get outdated soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can put all the files into a single
COPYcommand, but some of these are directories. If I add those to the COPY command then the contents of that directory will get copied into the target folder, but it will not actually create the target directory. So if ICOPY ${local_path}/config ethereumjs-monorepo/then it will not create aconfigfolder, it will instead dump all the files inside theethereumjs-monorepofolder. I have tried many combinations but I cannot seem to make the COPY command to create the folder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming you mean that you want to reduce the amount of COPY commands, right? So put all these COPYd files/directories into a single COPY command? Or do you mean that the file structure here might change? (Deleted/renamed files/directories?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant: https://stackoverflow.com/questions/37715224/copy-multiple-directories-with-one-command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I meant that the structure of the upstream sources can/will change. So the Dockerfile will require constant maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will cleanup these files since not all of these are necessary to run hive / the client. For our packages, it it not likely that we will add any packages in the near future, and even if we do so I would be very surprised if this would be more than 2 per year. However I can likely also prune that command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have cleaned up the unnecessary files. However, for the other ones (our packages) I do not want to clean this up, since this means we have to re-install and re-build everything once any of our packages changes (and this is very slow). It is unlikely we add more than 2 packages in a year, and have not planned any new packages so far, so "constant updating" is (likely) not going to happen.