Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simulators/ethereum/engine: Fix Cancun fcUV2 tests bugs #930

Closed
wants to merge 1 commit into from
Closed

simulators/ethereum/engine: Fix Cancun fcUV2 tests bugs #930

wants to merge 1 commit into from

Conversation

jangko
Copy link
Contributor

@jangko jangko commented Oct 24, 2023

  1. "ForkchoiceUpdatedV2 To Request Shanghai Payload, Zero Beacon Root"

    • test desc: "Payload Attributes uses Shanghai timestamp"
    • bug: ForkHeight: 1, generated timestamp is Cancun.
    • fix: ForkHeight: 2, generated timestamp is Shanghai.

  2. "ForkchoiceUpdatedV2 To Request Cancun Payload, Zero Beacon Root"

    • test desc: "Payload Attributes' Beacon Root zero"
    • bug: Payload Attributes' Beacon Root is not set/nil.
    • fix: set Payload Attributes's Beacon Root to zero.

@spencer-tb spencer-tb mentioned this pull request Oct 24, 2023
Merged
@jangko
Copy link
Contributor Author

jangko commented Oct 25, 2023

Close in favor of #902

@jangko jangko closed this Oct 25, 2023
@jangko jangko deleted the fix-engine-api-tests branch October 25, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jangko