Disallow importing private type via use
#815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/fix/use_pub
branch
2 times, most recently
from
1828733
to
a2c84a3
Compare
cburgdorf
force-pushed
the
christoph/fix/use_pub
branch
from
a2c84a3
to
32c92c4
Compare
cburgdorf
commented
Nov 16, 2022
| ┌─ compile_errors/bad_visibility/src/main.fe:1:68 | ||
| │ | ||
| 1 │ use foo::{MyInt, MY_CONST, MyStruct, MyTrait, my_func, MyContract, MyEnum } | ||
| │ ^^^^^^ not found |
There was a problem hiding this comment.
Not strictly related to the fix but the test was wrong in that it imported a non existing Enum rather than an enum that isn't pub.
cburgdorf
force-pushed
the
christoph/fix/use_pub
branch
from
32c92c4
to
563b791
Compare
cburgdorf
force-pushed
the
christoph/fix/use_pub
branch
from
563b791
to
4850e6c
Compare
|
Closing; already merged as part of #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We currently do not error when trying to import types via
usewhith are notpub. E.g.use foo::PrivateStructdoes not error.How was it fixed?
Trivial
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history