Add disable-hive flag
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
add-disable-hive-flag
branch
from
ba59442
to
b065f28
Compare
danceratopz
reviewed
Jul 18, 2023
There was a problem hiding this comment.
Looks good! But, I get identical fixtures for the following 2 commands:
fill -n auto -m blockchain_test --output=fixtures-hive-disabled-blockchain-tests-only --disable-hive
fill -n auto -m blockchain_test --output=fixtures-hive-enabled-blockchain-tests-onlySee comments below.
marioevz
force-pushed
the
add-disable-hive-flag
branch
from
b065f28
to
4cbe6ac
Compare
spencer-tb
approved these changes
Jul 18, 2023
danceratopz
force-pushed
the
add-disable-hive-flag
branch
from
4cbe6ac
to
14ef4b4
Compare
|
Rebased due to a minor conflict in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag that removes all hive related properties from the output fixtures.
At the moment it only removes the Engine API directive instructions.
Requires #207, hence draft.Rebased and removed dependency.