Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct fields to tx types #195

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Jul 5, 2023

There are a number of tests that vary across transaction types. Besu's t8n tool is sensitive to unsupported fields in some tx types and requires a value for other fields in those types.

This PR makes sure all required and no unsupported fields are in each TX type for cancun blob tx tests.

Ensure that the correct required transaction field are in each transaction
type, and that unsupported fields are absent.
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marioevz marioevz merged commit 0887658 into ethereum:main Jul 7, 2023
2 checks passed
@shemnon shemnon deleted the blob-tx-coretness branch July 7, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants