chore: enable python 311 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the only problem running our codebase with Python 3.11. Python 3.11 only allows default dataclass fields if they're hashable, see https://docs.python.org/3.11/whatsnew/3.11.html#dataclasses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of execution-spec-tests with Python 3.11.
More background on the dataclass fix:
By default, tox will run with current active version of Python. Github Actions now runs with 3.10 and 3.11:
execution-spec-tests/.github/workflows/test.yaml
Line 10 in 4b43545
This requires no changes to
tox.ini.I think this is enough checking, no need to add 310 and 311 environments to tox and burden the user with checking both versions locally - it's very unlikely that we'll break the other Python version. A break would be caught by CI/CD though.