Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -v --version t8n args for different t8ns #192

Closed
wants to merge 2 commits into from
Closed

fix -v --version t8n args for different t8ns #192

wants to merge 2 commits into from

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Jul 4, 2023

No description provided.

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -174,6 +175,10 @@ def __init__(
raise Exception("evm process unexpectedly returned a non-zero status code: " f"{e}.")
except Exception as e:
raise Exception(f"Unexpected exception calling evm tool: {e}.")
if not result.stdout.strip():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this check it does not seem reliable

@danceratopz
Copy link
Member

Hi @winsvega, I think this is now handled via the changes made to enable evm-one, see #142.

Also, this adds support for ethereum-spec-evm from execution-specs: #200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants