Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧱 Feature: Add the go-ethereum evm blocktest within tox #237

Closed
spencer-tb opened this issue Aug 1, 2023 · 2 comments
Closed

🧱 Feature: Add the go-ethereum evm blocktest within tox #237

spencer-tb opened this issue Aug 1, 2023 · 2 comments
Assignees
Labels
scope:ci Scope: Continuous Integration scope:evm Scope: evm_transition_tool package type:test Type: Test

Comments

@spencer-tb
Copy link
Collaborator

spencer-tb commented Aug 1, 2023

Feature Description

We have the occasional case where we may generate an invalid test fixture. Currently test fixtures can be checked for validity using the:

evm blocktest <path_to_fixture.json>

command from go-ethereum's evm.

To check the validity of all tests after generation, we could add an additional step during tox, that runs the above command on every generated fixture.

@spencer-tb spencer-tb changed the title 🧱 Improvement: Add the go-ethereum evm blocktest within tox 🧱 Feature: Add the go-ethereum evm blocktest within tox Aug 3, 2023
@spencer-tb spencer-tb self-assigned this Aug 6, 2023
@danceratopz danceratopz added scope:evm Scope: evm_transition_tool package type:test Type: Test labels Sep 26, 2023
@danceratopz
Copy link
Member

This will actually execute all the tests against geth, which might be overkill for our usual test.yaml workflow.

We could perhaps:

  1. Add a new tox environment that doesn't get ran by default, like testenv:tests-develop added in feature: Run development fork tests on github actions #302.
  2. Execute this test environment in a dedicated ci workflow. I'm not sure what this would look like, something executes daily on main and all branches from open PRs could be nice?

@danceratopz danceratopz added the scope:ci Scope: Continuous Integration label Sep 26, 2023
@spencer-tb
Copy link
Collaborator Author

This sounds like a great option 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration scope:evm Scope: evm_transition_tool package type:test Type: Test
Projects
None yet
Development

No branches or pull requests

2 participants