eth: remove methods to retrieve uncle counts

[lightclient]

fixes (by avoidance) #114

Removes the following methods related to uncle counts:

• eth_getUncleCountByBlockHash
• eth_getUncleCountByBlockNumber

Post-merge, methods related to uncles don't make much sense since per EIP-3675 it is not possible for a block to have ommers (uncles).

[smartprogrammer93]

No, i would keep it for retrieving this information for blocks before the merge. Once 4444 is implemented, only full archive nodes could keep it.

[lightclient]

This information is still available via eth_getBlockBy*. Currently we don't even have eth_getUncleBy* methods, so seems a bit moot to have the count getters.

[smartprogrammer93]

Yeah okay, makes sense

[lightclient]

Not super attached to this - just an idea. Just because it is removed from the spec doesn't mean that clients won't continue to support it for a long time. Just no longer a requirement.

[ryanschneider]

Also FWIW the existing uncle data available via RPC isn't enough to actually recreate the block fully from the JSONRPC data, since as you mentioned you need the eth_getUncleBy* methods, and those aren't currently in the spec.

So if anything, I'd advocate for adding in the uncle getters, which work totally fine w/o these count RPCs (you can always use eth_getBlockBy* and simply count the hashes in the uncle fields.

Of course I'm not saying we actually should include the uncle getters, just that I agree 100% these count getters are definitely not worth including.