Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844: engine_getBlobsBundleV1 specification, extension of engine API #197

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

protolambda
Copy link
Contributor

This is an extension to the Engine API for EIP-4844.

It enables the beacon-node to retrieves the bundle of blobs that is referenced by the blob-transactions in the execution payload.

This is a separate method in a separate document to avoid any collisions with the existing specification while the EIP is a draft and changes may be made.

It is also fully backwards compatible: the method is exposed, but can return an empty list of blobs and kzg commitments for any execution payload without blob transactions.

@protolambda
Copy link
Contributor Author

Update: force-pushed to extend the word-list to fix the spell check CI, it now includes "ssz", "kzg", and the blobs bundle method name and type

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I think this is the appropriate structure of the method imo

src/engine/eip4844.md Outdated Show resolved Hide resolved
src/engine/eip4844.md Outdated Show resolved Hide resolved
src/engine/eip4844.md Outdated Show resolved Hide resolved
src/engine/eip4844.md Outdated Show resolved Hide resolved
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@lightclient lightclient added the A-engine Area: for future consideration label May 19, 2022
@dgcoffman dgcoffman mentioned this pull request Oct 19, 2022
25 tasks
@timbeiko
Copy link
Collaborator

timbeiko commented Nov 1, 2022

@lightclient @mkalinin we agreed on the 4844 call today we'd like to merge this to have a separate API for blobs for now, and potentially move to having this in getPayloadV2 later. Any objection from either of you?

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the file to blob-extension.md or something similar? I don't think we should be using the EIP number as the sole identifier.

src/engine/eip4844.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine with me as long as it is fine with client developers to keep this version for testing purposes and then potentially switch to getPayloadV2.

For production spec, I would prefer to see blobs information incorporated into getPayloadV2 response as it prevents potential race conditions and reduces testing efforts that would be targeting those race condition scenarios.

@timbeiko timbeiko merged commit 619c3f7 into ethereum:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Area: for future consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants