state: Fix processing withdrawals of 0 #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
Jul 7, 2023
| @@ -123,6 +123,9 @@ void finalize(State& state, evmc_revision rev, const address& coinbase, | |||
| if (block_reward.has_value()) | |||
| state.touch(coinbase).balance += *block_reward; | |||
|
|
|||
| for (const auto& withdrawal : withdrawals) | |||
| state.touch(withdrawal.recipient).balance += withdrawal.get_amount(); | |||
There was a problem hiding this comment.
I don't remember why we implemented this in different order originally. The use of .touch() indicates we want the account to be cleared.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 81 81
Lines 8008 8008
=======================================
Hits 7800 7800
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I could confirm locally that this ( |
The withdrawals should be processed before state clearing so the empty accounts touched with 0 value withdrawals are also cleared from the state.
axic
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The withdrawals should be processed before state clearing so the empty accounts touched with 0 value withdrawals are also cleared from the state.
Fixes issue reported by ethereum/execution-spec-tests#142.