Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: Rename objects with prefix ExecutionLayerXXX #3791

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

prestonvanloon
Copy link
Contributor

Rationale:

Following #3757, which renames from DepositReceipt to DepositRequest to conform with the patterns in EIP-7685, this PR aims to have further conformity by dropping the ExecutionLayer prefix from WithdrawalRequest and ConsolidationRequest.

Changes:

  • Rename ExecutionLayerWithdrawalRequest->WithdrawalRequest
  • Rename ExecutionLayerConsolidationRequest->ConsolidationRequest
  • Rename process_execution_layer_withdrawal_request->process_withdrawal_request
  • Rename process_execution_layer_consolidation_request->process_consolidation_request
  • Rename variable/argument execution_layer_withdrawal_request->withdrawal_request
  • Rename variable/argument execution_layer_consolidation_request->consolidation_request

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed renaming makes sense to me as having both ExecutionLayer prefix and Request suffix looks redundant from my perspective

@hwwhww hwwhww mentioned this pull request Jun 6, 2024
10 tasks
@hwwhww hwwhww added the Electra label Jun 6, 2024
@hwwhww
Copy link
Contributor

hwwhww commented Jun 6, 2024

I like this clean-up! Hope to see more support (approvals/👍) before merging it.

@hwwhww hwwhww added the general:presentation Presentation (as opposed to content) label Jun 6, 2024
@hwwhww hwwhww force-pushed the rename-executionlayer-objs branch from 6e4bace to a6341af Compare June 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra general:presentation Presentation (as opposed to content)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants