-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 1 rebase #1504
Phase 1 rebase #1504
Conversation
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
… any genesis block
… modifications in phase 1
… forming crosslinks
…ERIOD in minimal config
Python 3.8 use in the spec now works thanks to the deposit contract PR. So CI passes, and re-introduces phase1 spec 🎉. Note that it's not perfect yet, and likely has some bugs left. It's experimental code after all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Rebase and replace #1483
-------- original comment from previous PR ------------
This PR continues the work of @vbuterin and #1427 contributors, rebases it to the latest branch dev branch (with v0.9.1 changes too), and refactors it for integration into the pyspec:
specs/old
. Some of it may still be relevant. To be removed from the spec once the last details are integrated well in the new docs.And I'm probably missing part of the new picture still, this is not my domain.More discussion helper. implemented custody revamp with the (simplified/faster) custody slashings 🎉Phase 0 and phase 1 are namespaced as modulesSame as previousPhase 1 type definitions overrule the phase 0 definitions. However, they inherit the phase0 types to make the new types compatible with the previous phase0 functions.Override with spec-builder. Imports from more modules result in import-loops and inheritance issues. Not to mention config reload problems.WIP: make pyspec SSZ correctly pick up that the super-type (phase 0) field annotations should be ignored in favor of the sub-type (phase 1) fieldsSee above