Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vyper b12->b13 #1497

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Vyper b12->b13 #1497

merged 1 commit into from
Nov 27, 2019

Conversation

CarlBeek
Copy link
Contributor

Brings the spec inline with the formal verification efforts which target Vyper V0.1.0-beta.13.

@CarlBeek CarlBeek requested a review from djrtwo November 26, 2019 19:45
@MrChico
Copy link
Member

MrChico commented Nov 26, 2019

Woah get_deposit_root() is 411927 gas cheaper

@djrtwo
Copy link
Contributor

djrtwo commented Nov 26, 2019

Thanks @CarlBeek! Can you rebase to v09x? Will release in next release and backport to dev

@CarlBeek CarlBeek changed the base branch from dev to v09x November 27, 2019 09:45
@CarlBeek
Copy link
Contributor Author

Woah get_deposit_root() is 411927 gas cheaper

@MrChico, yup it's very cool! It comes from the buffer overflow 0s trick from CALL_DATA_COPY.

@djrtwo, rebased for v09x, should be good to go.

@djrtwo djrtwo merged commit d150e4a into v09x Nov 27, 2019
@djrtwo djrtwo deleted the carl_vyper_v13 branch November 27, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
scope:deposit contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlBeek @MrChico @djrtwo