Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated attestation target root check #1492

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Remove duplicated attestation target root check #1492

merged 1 commit into from
Dec 4, 2019

Conversation

terencechain
Copy link
Contributor

assert target.root in store.blocks happened twice in on_attestation

@hwwhww hwwhww changed the base branch from master to v09x December 3, 2019 09:27
hwwhww
hwwhww approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to targeting at v09x branch. Looks good. 👍

@hwwhww hwwhww mentioned this pull request Dec 3, 2019
Merged
@djrtwo djrtwo merged commit e9dc2a1 into ethereum:v09x Dec 4, 2019
@terencechain terencechain mentioned this pull request Dec 12, 2019
Closed
11 tasks
@wemeetagain wemeetagain mentioned this pull request Jan 21, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
scope:fork-choice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @djrtwo @hwwhww