Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify previous_eth1_distance #1469

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Clarify previous_eth1_distance #1469

merged 1 commit into from
Nov 7, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Nov 7, 2019

Clarify previous_eth1_distance as discussed by @paulhauner in #1464

protolambda
protolambda approved these changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that it can change during the epoch and the start data should be tracked separately from the running mid epoch data. LGTM

@protolambda protolambda merged commit f099957 into v09x Nov 7, 2019
@protolambda protolambda deleted the fix-eth1-distance branch November 7, 2019 19:37
@djrtwo djrtwo mentioned this pull request Nov 8, 2019
Closed
@terencechain terencechain mentioned this pull request Nov 8, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @protolambda