Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electra block and state objects from CL spec #469

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

nflaig
Copy link
Collaborator

@nflaig nflaig commented Aug 26, 2024

Adds Electra block and state objects from CL spec as per v1.5.0-alpha.5 release and modifications from ethereum/consensus-specs#3875

Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/electra/block.yaml Outdated Show resolved Hide resolved
@nflaig
Copy link
Collaborator Author

nflaig commented Sep 16, 2024

need to apply changes from ethereum/consensus-specs#3875

@nflaig nflaig marked this pull request as draft September 16, 2024 10:26
@ralexstokes
Copy link
Member

need to apply changes from ethereum/consensus-specs#3875

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data

this would be mirrored in the builder-specs so that we don't need to worry about execution requests leaking any MEV in the builder exchange

@nflaig
Copy link
Collaborator Author

nflaig commented Sep 18, 2024

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data

makes sense, I applied the changes as per ethereum/builder-specs#101

@nflaig nflaig marked this pull request as ready for review September 18, 2024 11:08
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a somewhat quick skim, nice work!

@rolfyone
Copy link
Collaborator

Merging this as it at least should be close, and smaller PRs will be easier to adjust if any slight tweaks need to be made.

@rolfyone rolfyone merged commit 203410d into master Sep 23, 2024
3 checks passed
@rolfyone rolfyone deleted the nflaig/electra-spec-objects branch September 23, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants