-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint for fetching blinded blocks #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. should be easy to implement in teku, I know you were seeking opinions on that too...
9c1db6b
to
65eaaf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
65eaaf6
to
612ec1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise looks good!
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
This PR adds a new endpoint analogous to
/eth/v2/beacon/blocks/{block_id}
that serves blinded blocks rather than full blocks. The new endpoint is/eth/v1/beacon/blinded_blocks/{block_id}
.We already have other endpoints for creating new blinded blocks and POSTing signed blinded blocks back to the BN, so this PR completes the trilogy.
There are several reasons why such an endpoint is useful and desirable:
block_number
of the head block, without fetching all transactions.