snark: Handle only expected exceptions

Handle only expected exceptions around snark primitives precompiled, pass anything else higher.
ethereum · Jun 12, 2017 · 98ba0fd · 98ba0fd
1 parent 5b383c5
commit 98ba0fd
Showing 1 changed file with 5 additions and 15 deletions.
diff --git a/libdevcrypto/LibSnark.cpp b/libdevcrypto/LibSnark.cpp
@@ -164,11 +164,7 @@ pair<bool, bytes> dev::crypto::alt_bn128_pairing_product(dev::bytesConstRef _in)
 	}
 	catch (InvalidEncoding const&)
 	{
-		return {false, bytes{}};
-	}
-	catch (...)
-	{
-		cwarn << "Internal exception from libsnark. Forwarding as precompiled contract failure.";
+		// Signal the call failure for invalid input.
 		return {false, bytes{}};
 	}
 }
@@ -184,12 +180,9 @@ pair<bool, bytes> dev::crypto::alt_bn128_G1_add(dev::bytesConstRef _in)
 	}
 	catch (InvalidEncoding const&)
 	{
+		// Signal the call failure for invalid input.
+		return {false, bytes{}};
 	}
-	catch (...)
-	{
-		cwarn << "Internal exception from libsnark. Forwarding as precompiled contract failure.";
-	}
-	return {false, bytes{}};
 }
 
 pair<bool, bytes> dev::crypto::alt_bn128_G1_mul(dev::bytesConstRef _in)
@@ -203,10 +196,7 @@ pair<bool, bytes> dev::crypto::alt_bn128_G1_mul(dev::bytesConstRef _in)
 	}
 	catch (InvalidEncoding const&)
 	{
+		// Signal the call failure for invalid input.
+		return {false, bytes{}};
 	}
-	catch (...)
-	{
-		cwarn << "Internal exception from libsnark. Forwarding as precompiled contract failure.";
-	}
-	return {false, bytes{}};
 }