Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github usernames #990

Merged
merged 6 commits into from
Apr 11, 2018
Merged

Add Github usernames #990

merged 6 commits into from
Apr 11, 2018

Conversation

jamesray1
Copy link
Contributor

@jamesray1 jamesray1 commented Apr 10, 2018 •
edited
Loading

Added Github usernames and content from the original PR.

@jamesray1
Copy link
Contributor Author

What's the format for adding Github usernames in triangular brackets?

@5chdn
Copy link
Contributor

5chdn commented Apr 10, 2018

It appears you are not only adding GitHub usernames. What are the other additions about?

@nicksavers
Copy link
Contributor

@jamesray1 Look at https://github.com/ethereum/EIPs/blob/master/EIPS/eip-191.md for an example

@jamesray1
Copy link
Contributor Author

It appears you are not only adding GitHub usernames. What are the other additions about?

Yeah, I forgot to add that to the commit summaries. I was moving content from the PR to the EIP.

@jamesray1
Copy link
Contributor Author

Look at https://github.com/ethereum/EIPs/blob/master/EIPS/eip-191.md for an example

Yeah I thought it might be a simple @...

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 908 has no identifiable authors who can approve PRs

@jamesray1
Copy link
Contributor Author

Suggestions?

@5chdn
Copy link
Contributor

5chdn commented Apr 10, 2018 •
edited
Loading

From what I understand:

Real Name (@ Github Name) <Email Address>

@Arachnid
Copy link
Contributor

Use either Real Name (@githubid) or Real Name <email address>.

@nicksavers
Copy link
Contributor

The delimiter should be a comma.

@Arachnid Arachnid merged commit bd06a2e into ethereum:master Apr 11, 2018
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request May 2, 2018
@jamesray1 @Arachnid
Add Github usernames (ethereum#990)
15b1350 
* Add Github usernames

* Remove about.me link from triangular brackets

* Add @ before usernames, also note the previous commit was adding content from the original PR.

ethereum#908

* parentheses instead of triangular brackets: (@githubusername)

* replace and with ,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamesray1 @5chdn @nicksavers @eip-automerger @Arachnid