Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-4844: Disable Blob Transaction Broadcast #5930

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Update EIP-4844: Disable Blob Transaction Broadcast #5930

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71ff609
add EIP-5793 dependency
adietrichs Nov 14, 2022
75f34cf
specify no blob tx broadcast
adietrichs Nov 22, 2022
1c63a3a
Update EIPS/eip-4844.md
adietrichs Nov 22, 2022
6196173
clarify mandatory behavior
adietrichs Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions EIPS/eip-4844.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,9 @@ The actual `data_fee` as calculated via `calc_data_fee` is deducted from the sen

### Networking

Nodes must not automatically broadcast blob transactions to their peers.
Instead, those transactions are only announced using `NewPooledTransactionHashes` messages, and can then be manually requested via `GetPooledTransactions`.

Transactions are presented as `TransactionType || TransactionNetworkPayload` on the execution layer network,
the payload is a SSZ encoded container:

Expand Down Expand Up @@ -468,10 +471,11 @@ instead, they go into the `BeaconBlockBody`. This means that there is now a part
Blob transactions have a large data size at the mempool layer, which poses a mempool DoS risk,
though not an unprecedented one as this also applies to transactions with large amounts of calldata.

We recommend two solutions:
By only broadcasting announcements for blob transactions, receiving nodes will have control over which and how many transactions to receive,
allowing them to throttle throughput to an acceptable level.
[EIP-5793](./eip-5793.md) will give further fine-grained control to nodes by extending the `NewPooledTransactionHashes` announcement messages to include the transaction type and size.

- include a 1.1x (or potentially higher) data gasprice bump requirement to the mempool replacement rules
- modify the Ethereum Wire Protocol to stop automatically broadcasting large transactions
In addition, we recommend including a 1.1x data gasprice bump requirement to the mempool transaction replacement rules.
Copy link
Contributor

@xinbenlv xinbenlv Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In addition, we recommend including a 1.1x data gasprice bump requirement to the mempool transaction replacement rules.
In addition, we recommend including a 1.1x data gasprice bump requirement to the mempool transaction replacement rules.

Is the "recommendation" added here as a specification? Could you clarify if it's a comment or it's a specification?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is client-internal logic, so up to implementers to make decisions on. That's why it is not part of the EIP specification.


## Test Cases

Expand Down