Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft EIP: BLS12-381 Deterministic Account Hierarchy #2338

Closed
CarlBeek opened this issue Oct 31, 2019 · 6 comments
Closed

Draft EIP: BLS12-381 Deterministic Account Hierarchy #2338

CarlBeek opened this issue Oct 31, 2019 · 6 comments
Labels

Comments

@CarlBeek
Copy link
Contributor

CarlBeek commented Oct 31, 2019

Discussion for Draft EIP-XXXX: BLS12-381 Deterministic Account Hierarchy #2334.

This is the proposed standard for BLS12-381 Deterministic Account Hierarchy (Account Paths) for use within Eth2 as well as by the larger blockchain industry. Please be considerate of the implications of this standard in both the Eth2 and wider contexts.

@mcdee
Copy link
Contributor

mcdee commented Nov 8, 2019

I'm wondering if we should have a new coin type for Ethereum 2.

This does play in to 2334 a little, although given the different purpose it is possible for someone to differentiate between Ethereum and Ethereum 2 keys. But there are other systems out there that use coin type as the sole differentiator, for example ENS' multicoin address lookup.

I don't think there are any real downsides to having a new coin type, and given keeping the same coin type will definitely cause some issues I think a new coin type might be the safe option.

That said, the coin on both networks is still Ether so perhaps adding a new coin type is semantically incorrect. As you may tell, I'm undecided on this matter.

Thoughts?

@mariano54
Copy link

We are planning to support this format as well as EIP-2333 for Chia. I was wondering how finalized these specs were and if there are still changes to be made.

@MicahZoltu
Copy link
Contributor

I recommend modifying this to follow EIP-600, which defines how Ethereum HD Wallet derivation paths should be laid out. If BLS12-381 HD wallets don't have a concept of hardened and non-hardened then we can probably just ignore the hardening of the path?

@MicahZoltu
Copy link
Contributor

I should have read the motivation section before commenting 😬

The purpose needs to be distinct from these standards as the KDF and path are not inter-compatible and 12381 is an obvious choice.

Can you expand on the argument as to why the same path cannot be used? Is the idea that a user who has a mnemonic + derivation path would not need to also know what crypto algorithm is used?

@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 20, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants