Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pxhegvx to pxhegvd #1168

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Rename pxhegvx to pxhegvd #1168

merged 1 commit into from
Jun 21, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Jun 17, 2024

ScaLAPACK only implements pxhegvx, but the correct name for our implementation is pxhegvd (see LAPACK naming conventions).

This is a breaking change that will require changes to the Fortran API and its use by downstream projects (currently CP2K).

@RMeli
Copy link
Member Author

RMeli commented Jun 18, 2024

cscs-ci run

@RMeli RMeli marked this pull request as ready for review June 19, 2024 06:49
@rasolca rasolca added this to the v0.6.0 milestone Jun 19, 2024
@rasolca rasolca merged commit ce42f63 into eth-cscs:master Jun 21, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants