Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: panic after updating github.com/ugorji/go to v1.1.2 #10477

Closed
sysulq opened this issue Feb 15, 2019 · 3 comments
Closed

client: panic after updating github.com/ugorji/go to v1.1.2 #10477

sysulq opened this issue Feb 15, 2019 · 3 comments

Comments

@sysulq
Copy link
Contributor

sysulq commented Feb 15, 2019

go version 1.11.4

go get -v github.com/ugorji/go@v1.1.2

panic: codecgen version mismatch: current: 8, need 10. Re-generate file: C:/Users/liqi/go/pkg/mod/github.com/etcd-io/etcd@v3.3.12+incompatible/client/keys.generated.go

goroutine 1 [running]:
github.com/etcd-io/etcd/client.init.0()
        C:/Users/liqi/go/pkg/mod/github.com/etcd-io/etcd@v3.3.12+incompatible/client/keys.generated.go:45 +0x10b
exit status 2
FAIL          0.167s

This issue was caused by https://github.com/ugorji/go/blob/master/codec/gen-helper.generated.go#L17

The latest ugorji/go's GenVersion=10 and when we update ugorji/go to the latest version like v1.1.2

etcd/client finds out GenVersion != 8, and panic comes out...

please fix this ASAP, thanks a lot

#10370

@sysulq sysulq changed the title panic after update github.com/ugorji/go to v1.1.2 panic after updating github.com/ugorji/go to v1.1.2 Feb 15, 2019
@sysulq sysulq changed the title panic after updating github.com/ugorji/go to v1.1.2 client: panic after updating github.com/ugorji/go to v1.1.2 Feb 15, 2019
@hexfusion
Copy link
Contributor

hexfusion commented Feb 15, 2019

@hnlq715 The v2 client requires regeneration when using different versions of this package. Currently we are pinned to https://github.com/etcd-io/etcd/blob/master/go.mod#L45 v1.1.1 which had some go mod issues. I see the new version apparently better handles this issue.

So the solution would be to bump to 1.1.2 and regenerate the client keeping in mind the manual changes we made. #10337

Could you help us out with that and raise a PR to resolve?

@sysulq
Copy link
Contributor Author

sysulq commented Feb 16, 2019

Exactly, I'll handle this and raise a PR :-)

@sysulq
Copy link
Contributor Author

sysulq commented Feb 16, 2019

@hexfusion please check if I missed something in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants