Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular Expression not separating bible books and chapters correctly #14

Open
fitsie007 opened this issue Aug 8, 2022 · 4 comments
Open

Comments

@fitsie007
Copy link

Hello,
First, Thank you for this project. It is very helpful.
Second, I know your code is written in a language like Portuguese. Is it possible to translate to English?
If the code were in English, I would be able to fix the issue on my own.
I tried to get your code to work to download English versions of the bible (example ESV), but the regular expression is not separating the chapter from the book names properly. For example, if the book has a number in front, such as "1 Timothy", only the number is inserted into the database. This then triggers an issue when inserting the verse into the database. In some cases the word is inserted as a chapter instead of a number. Please see the attached images
openlp_book_error
openlp_chapter_error
below.

The initial url for the ESV version is https://nodejs.bible.com/api/bible/chapter/3.1?id=59&reference=

Thanks

@estevao90
Copy link
Owner

Hi @fitsie007.

So, Yeah. The code is written in Brazilian Portuguese. We can translate it, sure, but I need some time to translate it. Please feel free to submit a pull request if you want to deal with it.

Thank you for the detailed issue specification. I'll take a look at the weekend and fix it. :)

@fitsie007
Copy link
Author

Thanks. I am unable to fix the issue because I can't understand that portion of the code due to it being in Portuguese.

@estevao90
Copy link
Owner

No problem. I'll check it soon.

@estevao90
Copy link
Owner

Hi @fitsie007

Sorry for the delay.

I've fixed that issue. Could you please check if is it working?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants