Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save analysis is gone, migrate to SCIP #9

Open
est31 opened this issue Sep 19, 2022 · 9 comments
Open

Save analysis is gone, migrate to SCIP #9

est31 opened this issue Sep 19, 2022 · 9 comments

Comments

@est31
Copy link
Owner

est31 commented Sep 19, 2022

save-analysis is going away. For the short to mid term future, we can pin nightlies but with increased MSRV requirements, this will cause issues.

Some more info on it in this reddit thread.

@b-zee
Copy link
Contributor

b-zee commented Feb 23, 2023

Just wanted to come here to say I bumped into this when attempting to use this tool. save-analysis appears to have been removed last week, so I expect more people coming to this tool and running into a wall.

@est31
Copy link
Owner Author

est31 commented Feb 23, 2023

Yeah you will have to use a pinned older nightly, until I find time to migrate to SCIP. It's obviously not a trivial effort.

@b-zee
Copy link
Contributor

b-zee commented Feb 23, 2023

Yes, sorry if that came across as rude. This tool was perfect for my use case today. I can imagine it's not an easy task to migrate. Thanks a lot for your past work on this!

@est31
Copy link
Owner Author

est31 commented Feb 23, 2023

@b-zee no need to worry, you weren't rude or anything. ❤️

@est31 est31 changed the title Migrate to SCIP Save analysis is gone, migrate to SCIP Jul 27, 2023
@Matt3o12
Copy link

Matt3o12 commented Sep 6, 2023

Yeah you will have to use a pinned older nightly, until I find time to migrate to SCIP. It's obviously not a trivial effort.

Do you know which nightly release is the newest that still has save-analysis?

@est31
Copy link
Owner Author

est31 commented Sep 6, 2023

@Matt3o12 I'd try the 2023 February 15 or 16 binary, judging by this.

@lsunsi
Copy link

lsunsi commented Sep 14, 2023

I was so happy I found this crate, and then I saw it needed work to keep working. What does this migration entail? I don't think I have anything to offer, but I'd greatly benefit from having unused check across crates, so I want to at least subscribe to this.

@est31
Copy link
Owner Author

est31 commented Sep 14, 2023

The algorithmic part of this crate is rather small, most of it is in the parsing of the save analysis. So it would amount to a rewrite really.

@fenollp
Copy link

fenollp commented Sep 2, 2024

Is there a somewhat detailed plan that splits the move to SCIP in smaller parts? I'd like to get involved.

Finding dead code across crates sounds very useful to us :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants