Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant build generic from dev branch #646

Open
pvtex opened this issue Jun 12, 2024 · 5 comments
Open

cant build generic from dev branch #646

pvtex opened this issue Jun 12, 2024 · 5 comments

Comments

@pvtex
Copy link

pvtex commented Jun 12, 2024

i cant build generic image from dev branch.
this is the failure:

in rfid.esp in function genericRead() there is a Serial read in line 176.
this is no problem in debug build, because the Serial is set up.
but in generic build the Serial is not setup and the Serial avaiable and read are leading to a compile error.

@matjack1
Copy link
Collaborator

Hey @pvtex thank you for this report. I can successfully build, but I feel like you are right. This code that reads from serial has been there for a while though, so I'm not sure what has changed recently.

How are you building your project? I'm using Platformio and everything works well for me. Also the automatic build is working, so maybe there's something particular with your build process?

@pvtex
Copy link
Author

pvtex commented Jul 16, 2024

I am using platformio with visual code.
All on the newest version.
Even the included libraries are the newest version.
Perhabs there was a change.

@matjack1
Copy link
Collaborator

Maybe the problem is within the libraries, you should not have the newest versions, but the versions that come installed automatically by building with Platformio. Can you please try cleaning everything and rebuilding from scratch? You can use the "Full Clean" task and try building again. It should fetch all the libraries again and compile. Thanks!

@pvtex
Copy link
Author

pvtex commented Jul 23, 2024

But to make it failure proof that serial write should be there only i. Debug mode.
So put a ifdef DEBUG around it

@matjack1
Copy link
Collaborator

The problem is that some sensors are reading through the Serial, so it should stay there. I'll try that sensor soon and see if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants