Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuttx: esp32s3: fix compilation when enable mbedTLS in apps #2

Conversation

pkarashchenko
Copy link

No description provided.

Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
@tmedicci
Copy link
Collaborator

Hi @pkarashchenko ! Thanks for submitting it. Could you please provide a background (about what is failing on NuttX) and how to reproduce the issue?

@pkarashchenko
Copy link
Author

I'm trying to enable mbedTLS in NuttX app and build MQTT-C mbedTLS example.

@tmedicci
Copy link
Collaborator

I'm trying to enable mbedTLS in NuttX app and build MQTT-C mbedTLS example.

Thanks. I'll check...

Note that, for now, you can override the HAL with your own without changing any source code on NuttX. Just set env ESP_HAL_3RDPARTY_URL and ESP_HAL_3RDPARTY_VERSION before building. For instance:

ESP_HAL_3RDPARTY_URL="git@github.com:tmedicci/esp-hal-3rdparty.git" ESP_HAL_3RDPARTY_VERSION="improvement/rmt_driver" make

@pkarashchenko
Copy link
Author

Yes. I know. Initially I passed the build with only patching a header file, but later naming conflict happened when I enabled mbedTLS for MQTT

@pkarashchenko
Copy link
Author

Do you have results from internal CI?

@tmedicci
Copy link
Collaborator

Do you have results from internal CI?

I'm testing it right now. Yesterday afternoon I had another professional commitment.

We have an almost automated way of setting the prefixes (I'll make it public). There are other cases for inline functions that need to be set too. I'll let you know asap...

@tmedicci
Copy link
Collaborator

tmedicci commented Feb 23, 2024

@tmedicci
Copy link
Collaborator

@pkarashchenko , can you please double-check https://github.com/tmedicci/esp-hal-3rdparty/tree/bugfix/nuttx_mbedtls?

Any updates about it @pkarashchenko ?

@pkarashchenko
Copy link
Author

Will try out till Friday. Sorry, I'm having a busy week

@pkarashchenko
Copy link
Author

@tmedicci hi. Change works for me, but I posted one comment tmedicci@6fc8272#r139129194

@tmedicci
Copy link
Collaborator

@tmedicci hi. Change works for me, but I posted one comment tmedicci@6fc8272#r139129194

Could you please double-check same branch?

@pkarashchenko
Copy link
Author

Works well for me!

@tmedicci
Copy link
Collaborator

Solved with 55b60d9. Thanks @pkarashchenko !

@tmedicci tmedicci closed this Feb 29, 2024
@pkarashchenko pkarashchenko deleted the bugfix/nuttx_mbedtls branch February 29, 2024 19:07
pkarashchenko pushed a commit to apache/nuttx that referenced this pull request Feb 29, 2024
halyssonJr pushed a commit to halyssonJr/nuttx that referenced this pull request Apr 10, 2024
anchao pushed a commit to anchao/nuttx that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants