-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nuttx: esp32s3: fix compilation when enable mbedTLS in apps #2
nuttx: esp32s3: fix compilation when enable mbedTLS in apps #2
Conversation
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Hi @pkarashchenko ! Thanks for submitting it. Could you please provide a background (about what is failing on NuttX) and how to reproduce the issue? |
I'm trying to enable mbedTLS in NuttX app and build MQTT-C mbedTLS example. |
Thanks. I'll check... Note that, for now, you can override the HAL with your own without changing any source code on NuttX. Just set env
|
Yes. I know. Initially I passed the build with only patching a header file, but later naming conflict happened when I enabled mbedTLS for MQTT |
Do you have results from internal CI? |
I'm testing it right now. Yesterday afternoon I had another professional commitment. We have an almost automated way of setting the prefixes (I'll make it public). There are other cases for inline functions that need to be set too. I'll let you know asap... |
@pkarashchenko , can you please double-check https://github.com/tmedicci/esp-hal-3rdparty/tree/bugfix/nuttx_mbedtls? |
Any updates about it @pkarashchenko ? |
Will try out till Friday. Sorry, I'm having a busy week |
@tmedicci hi. Change works for me, but I posted one comment tmedicci@6fc8272#r139129194 |
Could you please double-check same branch? |
Works well for me! |
This commit closes #11738. Actual fix is tracked in: espressif/esp-hal-3rdparty#2
Solved with 55b60d9. Thanks @pkarashchenko ! |
This commit closes #11738. Actual fix is tracked in: espressif/esp-hal-3rdparty#2
This commit closes apache#11738. Actual fix is tracked in: espressif/esp-hal-3rdparty#2
This commit closes apache#11738. Actual fix is tracked in: espressif/esp-hal-3rdparty#2
No description provided.