Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPClient should allow for setting own Accept-Encoding header #9861

Closed
1 task done
fleinze opened this issue Jun 14, 2024 · 2 comments · Fixed by #9863
Closed
1 task done

HTTPClient should allow for setting own Accept-Encoding header #9861

fleinze opened this issue Jun 14, 2024 · 2 comments · Fixed by #9863
Labels
Status: In Progress Issue is in progress Type: Feature request Feature request for Arduino ESP32
Milestone

Comments

@fleinze
Copy link

fleinze commented Jun 14, 2024

Related area

HTTPClient

Hardware specification

all ESP32 boards

Is your feature request related to a problem?

Currently the Library automatically adds the header "Accept-Encoding: identity;q=1,chunked;q=0.1,*;q=0\r\n", except when using HTTP1.0.
This can be a problem in some cases and can not be changed without editing the library source.
Adding a custom Accept-Encoding-header with addHeader() will result in two headers beeing sent.

Describe the solution you'd like

Add a function e.g. HTTPClient::setAcceptEncoding similar to HTTPClient::setUserAgent for overriding the default Accept-Encoding header.

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@me-no-dev
Copy link
Member

Done: #9863 😄

@fleinze
Copy link
Author

fleinze commented Jun 14, 2024

Well, that was fast. Thank you!

@VojtechBartoska VojtechBartoska added the Status: In Progress Issue is in progress label Jun 17, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.2 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Issue is in progress Type: Feature request Feature request for Arduino ESP32
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants