Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we still need to backup asm c and c++ flags before we run cmake config? #309

Open
Vollbrecht opened this issue May 30, 2024 · 1 comment
Open

do we still need to backup asm c and c++ flags before we run cmake config? #309

Vollbrecht opened this issue May 30, 2024 · 1 comment
Labels
question Further information is requested

Comments

@Vollbrecht
Copy link
Collaborator

In our buildscript here we do this backup, but the linked issue seams to be resolved in upstream from v5.0..v5.4.

This is the commit that closed the upstream issue.
@Vollbrecht
Copy link
Collaborator Author

@ivmarkov if you can give your short opinion here when you feel like thinking about it it would be appreciated.

@Vollbrecht Vollbrecht added the question Further information is requested label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
esp-rs
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vollbrecht