Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the links field to the Cargo manifest of esp-println and potentially other packages #1731

Closed
jessebraham opened this issue Jun 27, 2024 · 2 comments · Fixed by #1761
Closed
Assignees
Labels
package:esp-println Issues related to the esp-println package
Milestone

Comments

@jessebraham
Copy link
Member

It's currently possible to accidentally include multiple versions of esp-println in your project, which results in compilation errors when the build script is performing the feature verification.

This should be resolvable by simply adding links = "esp-println" to esp-println/Cargo.toml under the [package] section.

Additionally, we should evaluate which, if any, other packages should receive this change, and update all relevant packages.

@jessebraham jessebraham added the package:esp-println Issues related to the esp-println package label Jul 4, 2024
@jessebraham
Copy link
Member Author

@bjoernQ I'm not sure any other packages really need it at this point, can you think of any? If not I'll add this field and close this issue.

@jessebraham jessebraham self-assigned this Jul 4, 2024
@jessebraham jessebraham added this to the 0.19.0 milestone Jul 4, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 5, 2024

@bjoernQ I'm not sure any other packages really need it at this point, can you think of any? If not I'll add this field and close this issue.

I don't think any other package needs it - thanks for taking care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:esp-println Issues related to the esp-println package
Projects
Archived in project
2 participants