-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIERARCH + CONTINUE doesn't work. #358
Comments
In my quick test with Rubin code using cfitsio I ended up with a header that looks like this:
so the |
Fitsio bundles cfitsio due to some features around Unicode strings that have not been upstreamed. If you have a patch that fixes the bug, we can add it to the patches we carry locally. |
Any news on this one? |
I haven't tried v4.4.0 of cfitsio but the release notes on https://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/docs/changes.txt mention long keywords but not HIERARCH so I don't know if it got fixed. I definitely didn't get an email about it from them and I sent a follow up to my email from 18 months ago. |
I am told this was fixed in cfitsio 4.3.0:
|
I'll look into bundling 4.4.0 and using the new functions |
Moving to 4.4.0 fixed the bug without any changes in this package |
fitsio can read/write long value items into a header using CONTINUE lines. And it can read/write long keyword names with HIERARCH lines. However, combining the two fails. Here is a quick unit test, which fails:
Output:
Note: This came up on LSST Slack (see thread on software-dev channel Jan 24, 10:28 AM EST). It seems to be a bug in the backend cfitsio implementation. Tim Jenness sent an email to cfitsio devs to report the issue. I'm not sure if it's possible for fitsio to work around this or not to fix the bug sooner, rather than just wait for cfitsio to fix it.
The text was updated successfully, but these errors were encountered: